Skip to content

gh#197: Enable/Disable application specific audio configuration data. - #203

Merged
kanjoe24 merged 2 commits into
developfrom
feature/gh-197-app-audio-config
Jul 14, 2026
Merged

gh#197: Enable/Disable application specific audio configuration data.#203
kanjoe24 merged 2 commits into
developfrom
feature/gh-197-app-audio-config

Conversation

@shashank4388

Copy link
Copy Markdown

Introducing a new api in device settings to enable/disable application specific audio config data.

Copilot AI review requested due to automatic review settings July 6, 2026 12:15
@shashank4388
shashank4388 requested a review from a team as a code owner July 6, 2026 12:15
@shashank4388 shashank4388 linked an issue Jul 6, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new Device Settings Audio HAL API to enable/disable application-specific audio configuration behaviors, along with a type to expose the supported configuration list.

Changes:

  • Add dsApplicationAudioConfigList_t and MAX_AUDIO_CONFIG_BUFFER_LEN to carry a comma-separated list of supported app audio configurations.
  • Add new public APIs to set/get an application audio configuration enable state and to query the supported configuration list.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
include/dsAVDTypes.h Adds a new buffer length macro and a struct for returning supported application audio configuration names + count.
include/dsAudio.h Adds new public HAL APIs for setting/getting an app-specific audio configuration and querying the supported list, with Doxygen documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 364b355 to b76143b Compare July 7, 2026 09:56
Comment thread include/dsAudio.h Outdated
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from b76143b to 657ee86 Compare July 8, 2026 11:37
Copilot AI review requested due to automatic review settings July 8, 2026 11:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAVDTypes.h Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 11:47
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 657ee86 to 04fd436 Compare July 8, 2026 11:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 11:54
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 04fd436 to b4438b4 Compare July 8, 2026 11:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAVDTypes.h Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 12:13
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from b4438b4 to ddee2d3 Compare July 8, 2026 12:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Copilot AI review requested due to automatic review settings July 8, 2026 12:23
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from ddee2d3 to 0c3dd1a Compare July 8, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

Comment thread include/dsAVDTypes.h
Comment thread include/dsAVDTypes.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Copilot AI review requested due to automatic review settings July 10, 2026 11:55
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 0c3dd1a to bbd0dab Compare July 10, 2026 11:55
@shashank4388 shashank4388 changed the title gh#197: Enable/Disable applicatio specific audio configuration data. gh#197: Enable/Disable application specific audio configuration data. Jul 13, 2026
Copilot AI review requested due to automatic review settings July 13, 2026 11:17
@shashank4388
shashank4388 dismissed stale reviews from AnandPandav and outdooruseonly via 61fe2ec July 13, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comment thread include/dsAVDTypes.h
Comment thread include/dsAVDTypes.h
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Comment thread include/dsAudio.h Outdated
Copilot AI review requested due to automatic review settings July 13, 2026 11:47
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 61fe2ec to 1c10d3b Compare July 13, 2026 11:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

Comment thread include/dsAVDTypes.h
Comment thread include/dsAVDTypes.h
Comment thread include/dsAudio.h
Copilot AI review requested due to automatic review settings July 14, 2026 10:04
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 1c10d3b to aa4e1e6 Compare July 14, 2026 10:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread include/dsAudio.h Outdated
Copilot AI review requested due to automatic review settings July 14, 2026 10:11
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from aa4e1e6 to 9393058 Compare July 14, 2026 10:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@shashank4388
shashank4388 changed the base branch from main to develop July 14, 2026 10:16
@shashank4388
shashank4388 force-pushed the feature/gh-197-app-audio-config branch from 9393058 to 8a8b893 Compare July 14, 2026 10:19

@srinivasgtl srinivasgtl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@kanjoe24

Copy link
Copy Markdown
Contributor

@shashank4388 , can you resolve the conversation please.

@outdooruseonly outdooruseonly left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK again!

@shashank4388

Copy link
Copy Markdown
Author

@shashank4388 , can you resolve the conversation please.

@kanjoe24 resolved all the conversations

@kanjoe24
kanjoe24 merged commit 2c6bff3 into develop Jul 14, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Enable/Disable Application specific audio configuration

9 participants